This repository has been archived by the owner on Sep 4, 2019. It is now read-only.
Implemented blackberry.io.filetransfer download and upload tests #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass, except for download and upload since I'm on VPN. Can we get someone onsite to retest to confirm? |
|
We should move the upload service onto the CI server which is on all the time, then these testcases should pass. |
|
@jengee It already was on the CI server :). We need to setup XAMPP as a service that runs on system reboots. |
-Fixed minor issue with blackberry.io.filetransfer.PERMISSIONS_ERR
|
Much better. Pass. |
|
I think this API should be deprecated in favour of the Cordova plugin. If we are going to add these tests, they should be hosted in the lab along with the cross origin tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup a upload server on the CI machine.
With this complete, blackberry.io.filetransfer is now fully automated and can be run by anyone.