Update to toml_edit 0.22 #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this time it does not involve a MSRV bump :) |
bkchr
approved these changes
Feb 12, 2024
|
Doesn't look CI supports your statement 👀 |
|
Huh, did I fail reading and confused 7 with 9 😕 Sorry! |
|
What is the status here? Bumping MSRV is unfortunately still a mess, with different opinions and conventions. But perhaps the MSRV should just be bumped here without a major version bump - those caring about being compatible with rust 1.68 and 1.69 can still version pin (it's for sure not an ideal situation, but perhaps the most practical)? |
|
Just a note about MSRV: Rust 1.69 is now almost as old as 1.67 was when this PR was submitted. This may or may not mean anything, but I think it's relevant. :) |
|
Bump...? 😶 |
|
Done in: #52 |
|
Yay, thanks! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.