Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12967] Create bitwarden-wasm-internal #1089

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 27, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12967

📔 Objective

PM SDK. Based on the research spike in #1077

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 27, 2024

Logo
Checkmarx One – Scan Summary & Detailsa3bb6e36-d0aa-454d-8878-3dad461a11d4

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 58.32%. Comparing base (66949af) to head (bb20e46).

Files with missing lines Patch % Lines
crates/bitwarden-wasm-internal/src/client.rs 0.00% 27 Missing ⚠️
...rates/bitwarden-core/src/client/client_settings.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
- Coverage   58.44%   58.32%   -0.13%     
==========================================
  Files         192      193       +1     
  Lines       13528    13557      +29     
==========================================
  Hits         7907     7907              
- Misses       5621     5650      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton changed the title Create bitwarden-wasm-internal [PM-12967] Create bitwarden-wasm-internal Sep 30, 2024
@Hinton Hinton marked this pull request as ready for review September 30, 2024 08:58
@Hinton Hinton requested a review from a team as a code owner September 30, 2024 08:58
Comment on lines +71 to +76
- name: Publish NPM
if: ${{ github.ref == 'refs/heads/main' }}
run: npm publish --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
working-directory: languages/js/sdk-internal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should split the build and publish workflows. If it's needed to publish it on every push to main, I suggest triggering the publishing workflow here. An example of that can be found in the build-swift.yml workflow:

- name: Trigger Swift release
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
github-token: ${{ steps.retrieve-secret-pat.outputs.github-pat-bitwarden-devops-bot-repo-scope }}
script: |
await github.rest.actions.createWorkflowDispatch({
owner: 'bitwarden',
repo: 'sdk',
workflow_id: 'release-swift.yml',
ref: 'main',
inputs: {
'build-run-id': '${{ github.run_id }}',
'pre-release': 'true'
}
})

BTW is it released to npmjs.com or to github packages?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently gh packages, but we will probably change it to npmjs.

…m-internal

# Conflicts:
#	Cargo.toml
#	crates/bitwarden-core/Cargo.toml
#	crates/bitwarden/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants