-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-12967] Create bitwarden-wasm-internal #1089
base: main
Are you sure you want to change the base?
Conversation
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1089 +/- ##
==========================================
- Coverage 58.44% 58.32% -0.13%
==========================================
Files 192 193 +1
Lines 13528 13557 +29
==========================================
Hits 7907 7907
- Misses 5621 5650 +29 ☔ View full report in Codecov by Sentry. |
- name: Publish NPM | ||
if: ${{ github.ref == 'refs/heads/main' }} | ||
run: npm publish --access public | ||
env: | ||
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
working-directory: languages/js/sdk-internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should split the build and publish workflows. If it's needed to publish it on every push to main
, I suggest triggering the publishing workflow here. An example of that can be found in the build-swift.yml workflow:
sdk/.github/workflows/build-swift.yml
Lines 101 to 115 in 90f8a54
- name: Trigger Swift release | |
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 | |
with: | |
github-token: ${{ steps.retrieve-secret-pat.outputs.github-pat-bitwarden-devops-bot-repo-scope }} | |
script: | | |
await github.rest.actions.createWorkflowDispatch({ | |
owner: 'bitwarden', | |
repo: 'sdk', | |
workflow_id: 'release-swift.yml', | |
ref: 'main', | |
inputs: { | |
'build-run-id': '${{ github.run_id }}', | |
'pre-release': 'true' | |
} | |
}) |
BTW is it released to npmjs.com or to github packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently gh packages, but we will probably change it to npmjs.
…m-internal # Conflicts: # Cargo.toml # crates/bitwarden-core/Cargo.toml # crates/bitwarden/Cargo.toml
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12967
📔 Objective
PM SDK. Based on the research spike in #1077
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes