Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing wrong precision over accumulated collateral fees amount #3664

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AmmarYousefM
Copy link
Contributor

Fixing wrong precision over accumulated collateral fees amount (TEXT BOX).

@@ -79,7 +79,7 @@ class FeePoolOperation extends React.Component {
claimCollateralFeesAmount: 0,
claimCollateralFeesAmountAsset: new Asset({
amount: 0,
precision: this.props.asset.get("precision"),
precision: this.props.core.get("precision"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. In fact, the asset type of the collateral fee is just the backing asset (see code below), it could be another asset, but not only core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants