Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/schema-registry] keystore is not mandatory for SASL_SSL protocol #71059

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[bitnami/schema-registry] keystore is not mandatory for SASL_SSL protocol #71059

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0a8130
keystore is not mandatory for SASL_SSL protocol
masfworld Aug 20, 2024
17f750b
keystore is not mandatory for SASL_SSL protocol
masfworld Aug 20, 2024
1386bbf
Merge branches 'sasl_ssl_no_keystore' and 'sasl_ssl_no_keystore' of g…
masfworld Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bitnami/schema-registry/7.6/debian-12/rootfs/opt/bitnami/scripts/libschemaregistry.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ schema_registry_validate() {

if [[ -n "$SCHEMA_REGISTRY_KAFKA_BROKERS" ]]; then
if brokers_auth_protocol="$(schema_registry_brokers_auth_protocol)"; then
if [[ "$brokers_auth_protocol" =~ SSL ]]; then
# Keystore is not mandatory for SASL_SSL
if [[ "$brokers_auth_protocol" =~ SSL ]] && [[ ! "$brokers_auth_protocol" =~ SASL_SSL ]] && [[ -v "$SCHEMA_REGISTRY_CERTS_DIR" ]]; then
if [[ ! -f ${SCHEMA_REGISTRY_CERTS_DIR}/schema-registry.keystore.jks ]] || [[ ! -f ${SCHEMA_REGISTRY_CERTS_DIR}/schema-registry.truststore.jks ]]; then
print_validation_error "In order to configure the TLS encryption for communication with Kafka brokers, you must mount your schema-registry.keystore.jks and schema-registry.truststore.jks certificates to the ${SCHEMA_REGISTRY_CERTS_DIR} directory."
fi
Expand Down Expand Up @@ -302,7 +303,7 @@ schema_registry_initialize() {
schema_registry_conf_set "kafkastore.sasl.jaas.config" "$aux_string"
fi

if [[ "$brokers_auth_protocol" =~ SSL ]]; then
if [[ "$brokers_auth_protocol" =~ SSL ]] && [[ -v "$SCHEMA_REGISTRY_CERTS_DIR" ]]; then
schema_registry_conf_set "kafkastore.ssl.keystore.location" "${SCHEMA_REGISTRY_CERTS_DIR}/schema-registry.keystore.jks"
[[ -n "$SCHEMA_REGISTRY_KAFKA_KEYSTORE_PASSWORD" ]] && schema_registry_conf_set "kafkastore.ssl.keystore.password" "$SCHEMA_REGISTRY_KAFKA_KEYSTORE_PASSWORD"
schema_registry_conf_set "kafkastore.ssl.truststore.location" "${SCHEMA_REGISTRY_CERTS_DIR}/schema-registry.truststore.jks"
Expand Down
Loading