-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/airflow] Add libraries libpq-dev python-dev gcc to support installation psycopg2 as dependency #48258
base: main
Are you sure you want to change the base?
Conversation
…g2 as dependency Signed-off-by: oktay <[email protected]>
Hi @oktayalizada, I have built the image locally, and it appears to be quite large:
I believe the intention in bitnami/charts#19242 was to create a fork rather than modify the bitnami airflow images. Adding these additional packages would need additional analysis, including an assessment of image size and the need for these packages. For instance, adding python-dev may include more packages than necessary. Please let me know if there are any additional details I may be overlooking. |
Hi @fevisera, |
Hi @oktayalizada, Thank you for your question! I did not mean to imply that Airflow will not support the installation and usage of the psycopg2 library for bitnami/airflow. What I intended to convey is that before adding those new packages, it is essential to conduct a more thorough analysis to assess the image size impact and the actual necessity of these packages. We already have an ongoing internal task to address adding dependencies feature, which has been created for #48258. As soon as this functionality becomes available, we will notify you here. Thank you for proposing this change and bringing it to our attention. If you have any more questions or concerns, please feel free to ask. We appreciate your feedback. |
Description of the change
The change introduces three new packages which will be installed in airflow pods to support installation of psycopg2 library from requirements.txt file.
Currently if we add psycopg2 library to requirements.txt we will get an error:
Error: pg_config executable not found.
Benefits
Possibility to use bitnami images and helm chart to install psycopg2 and other libraries which depend on it
Applicable issues