-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/style: landing page #7
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1380c83
build: install bdp-ui icons
IgboPharaoh 1c302b8
build: set config requirements
IgboPharaoh a81fb2a
style: add assets and icons
IgboPharaoh 18ab7c9
chore: remove redundant styles, add menu data
IgboPharaoh 1ff9fa0
chore: add landing page components
IgboPharaoh e540db7
chore: create landing page with responsive styles
IgboPharaoh d71c49b
fix: build error
IgboPharaoh 9f86b99
replace image assets
IgboPharaoh f98ce5b
add mobile menu and app menu
IgboPharaoh adfada7
install bdp-ui from npm
IgboPharaoh 55dd3c3
complete landing page requirements
IgboPharaoh bb911d4
remove search icon, change image path and add priority prop
IgboPharaoh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I forgot the
contentDirExclude
when I did the refactoring.Does
".json"
means that it's excluding all the JSON files?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it doesn't, this and other things in the
contentDirExclude
array just excludes files at the root directoryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it excludes all JSON files in the root directory? If that's the case then you don't need to separate specify
"twitter_handles.json"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me tag this comment to the pr in prod