Add HeterogeneousEqual and HeterogeneousNotEqual to binary operation #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tipnos
changed the title
divarvel
reviewed
May 24, 2024
divarvel
reviewed
May 24, 2024
| expression.ops.iter().any(|op| match op { | ||
| Op::Value(term) => contains_v5_term(term), | ||
| Op::Binary(binary) => match binary { | ||
| Binary::HeterogeneousEqual | Binary::HeterogeneousNotEqual => true, |
Tipnos
force-pushed
the
heterogeneous-equals-optin
branch
3 times, most recently
from
97d0a9f
to
d44f9bd
Compare
Tipnos
force-pushed
the
heterogeneous-equals-optin
branch
from
d44f9bd
to
0076b78
Compare
divarvel
approved these changes
May 24, 2024
Geal
reviewed
May 25, 2024
Geal
approved these changes
May 25, 2024
Geal
reviewed
May 26, 2024
Geal
reviewed
May 26, 2024
Co-authored-by: Clément Delafargue <[email protected]>
Geal
reviewed
May 26, 2024
|
this is good to go, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes biscuit-auth/biscuit#130 with backward compatibility for existing biscuit