Reject if #199
Merged
Reject if #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This acts like the opposite of `check if`: if there is a match, then authorization fails. Using `reject if` raises the block version to 5
The file contained trailing slashes that made rustfmt crash
| let mut contains_check_all = false; | ||
| let mut contains_reject_if = false; | ||
|
|
||
| for c in checks.iter() { |
There was a problem hiding this comment.
Couldn't be simplified with a contains ?
There was a problem hiding this comment.
we are setting two separate flags, so using contains (or any as before) would require traversing the list twice.
Geal
reviewed
Dec 29, 2023
Geal
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See biscuit-auth/biscuit#141
This adds
reject ifsupport to the parser as well as the serialization layer, raising the block version to 5 when used.This PR does not introduce an equivalent to
reject if allbecause i'm not sure what it would look like and whether it would be useful.