Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rtwindow snap fix #903

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Rtwindow snap fix #903

merged 3 commits into from
Sep 6, 2024

Conversation

bkieft-usa
Copy link
Collaborator

An update was needed to the block that accounts for atlas entries with missing inchi keys. Since a missing key is initialized with a blank string, a more specific if statement was used when assigning similar compound hits.

Copy link
Collaborator

@tharwood3 tharwood3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I appreciate the added logging. Feel free to merge into main when ready.

@bkieft-usa bkieft-usa merged commit 16bc8fd into main Sep 6, 2024
5 of 6 checks passed
@bkieft-usa bkieft-usa deleted the rtwindow_snap_fix branch September 6, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants