Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bactopia to v1.6.2 #27482

Merged
merged 4 commits into from
Mar 21, 2021
Merged

Update bactopia to v1.6.2 #27482

merged 4 commits into from
Mar 21, 2021

Conversation

rpetit3
Copy link
Member

@rpetit3 rpetit3 commented Mar 21, 2021

Auto updater missed this one


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@rpetit3
Copy link
Member Author

rpetit3 commented Mar 21, 2021

Tests pass first round, but fail on the container. It's likely related to this: puniverse/capsule#135

CAPSULE EXCEPTION: Could not parse version: 11.0.9.1-internal while processing attribute Min-Java-Version: 1.8.0 (for stack trace, run with -Dcapsule.log=verbose)

I had to pin the JDK version to 11.0.8, to make the test pass. I'm not a big fan of this, but it doesn't look like the issue is going to be fixed on the Capsule side of things.

I also pinned the AMRFinder+ version to match the version used by a Bactopia subprocess.

@rpetit3
Copy link
Member Author

rpetit3 commented Mar 21, 2021

@BiocondaBot please add label

@rpetit3
Copy link
Member Author

rpetit3 commented Mar 21, 2021

@BiocondaBot please fetch artifacts

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Mar 21, 2021
@BiocondaBot
Copy link
Collaborator

Package(s) built on CircleCI are ready for inspection:

Arch Package Repodata
noarch bactopia-1.6.2-0.tar.bz2 repodata.json

You may also use conda to install these:

  • For packages on noarch:
conda install -c https://146532-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag Install with docker
bactopia 1.6.2--0
showcurl "https://146532-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/bactopia%3A1.6.2--0.tar.gz" | gzip -dc | docker load

@telatin
Copy link
Member

telatin commented Mar 21, 2021

Thanks for fixing the recipe with JDK version pin.

@rpetit3
Copy link
Member Author

rpetit3 commented Mar 21, 2021

@BiocondaBot please merge

@rpetit3
Copy link
Member Author

rpetit3 commented Mar 21, 2021

@telatin thank you!

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot BiocondaBot merged commit 34f0470 into master Mar 21, 2021
@BiocondaBot BiocondaBot deleted the rpetit3-patch-3 branch March 21, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants