Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When I did #388 I was wondering why that parsers plug stuff was in the router not the endpoint!
I realize I put it in there following this guide: https://github.com/tallarium/reverse_proxy_plug?tab=readme-ov-file#usage-in-phoenix
Before #388 we wouldn't do the MethodOverride plug, which is what lets the frontend have buttons that use the
DELETE
method (it has a special parameter that MethodOverride turns into a DELETE methoded request).After #388 we were parsing all requests, including those for the proxy to analytics, so the proxy wouldn't have any body to send when sending post requests.
I've now added a cache for bodies for requests to /analytics/* following the guide linked above
🤞
Checklist before requesting a review
about this update in the description above.