fix: reposition flash on mobile. #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teesloane
force-pushed
the
346-flash-on-mobile
branch
from
f3c01f4
to
b8ef155
Compare
mveytsman
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #346
I was originally overthinking this - adding a new flash library is fairly involved. Why not just move the flash down to within thumbs reach on mobile (and get it out of the way of menu).
If we need to explore future flash libraries, Flashy looks good, and so does LiveToast. Both involve having to setup JS hooks.
Screenshot
CleanShot.2024-06-03.at.16.48.36.mp4
Checklist before requesting a review
about this update in the description above.