Fix: sort tasks by neighbourhoods. #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teesloane
commented
Apr 26, 2024
lib/bike_brigade/delivery.ex
Outdated
Comment on lines
462
to
463
| Repo.preload(all_tasks, assigned_rider: fn _ -> all_riders end) | ||
| |> Enum.sort_by(fn t -> t.dropoff_location.neighborhood.name end) |
There was a problem hiding this comment.
@mveytsman tried to figure out how to do this at the DB level for too long and gave up. Happy to 🍐 if you know a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pairing with @chadmohr he mentioned that we might want to consider grouping tasks by neighbourhood — sometimes tasks are all going to the same building / is useful for riders who can/want to take multiple deliveries to the same location.
Before
After