140 - Rider campaign signup #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need three new routes: - an "index" for showing campaigns to signup for (like the existing campaigns view for dispatchers) - a "show" for showing what tasks are available to signup for for a single campaign. - a "rider_signup" for the form component for the rider signing up.
We will need to use this function from the rider signup view for riders to be able to unassign themselves. The "current_user" only has a "rider_id", which would require us to preload the rider or fetch the current_user's rider in order to use this function in its current state. Since the query only makes use of the rider's id, we can just pass that.
A more efficient query for determining how many tasks exist per campaign, and how many of them are open (as opposed to preloading tasks on all campaigns).
This view is responsible for showing riders a list of campaigns which will have varying CTA's depending on how full they are.
teesloane
force-pushed
the
140-rider-campaign-signup-pt-1
branch
from
7717ba2
to
4385f44
Compare
teesloane
commented
Dec 12, 2023
| <.get_delivery_size task={task}/> | ||
| </:col> | ||
| <:col :let={task} label="Recipient"><%= task.dropoff_name %></:col> | ||
| <:col :let={task} label="Dropoff Location"><%= task.dropoff_location.address %></:col> |
There was a problem hiding this comment.
Right now this shows the exact address of the Task. Is this what we want?
mveytsman
requested changes
Jan 2, 2024
There was a problem hiding this comment.
- When singing up, riders shouldn't see exact location of the task
- Switch to showing neighbourhood or abstracted location
- bug about navigating via "back button" when rider signs up for themselves
- leave a note on
campaign_signup_live/index.exabout the database fetching - "Campaign Filled" should be no colour?
- Remove rider signup form - so just click and it does it.
- Remove "capacity" and "pickup window" from rider signup form
- Maybe remove enter buildings
- consider adding a rider setting that enables people to choose how much of their PI is shown when singing up
- nick name, full name, etc
| @impl Phoenix.LiveView | ||
| def handle_info({event, entity}, socket) when event in @broadcasted_infos do | ||
| campaign = socket.assigns.campaign | ||
| # if a task or a campaign rider changes (ie, if any of hte broadcasted_infos) |
teesloane
force-pushed
the
140-rider-campaign-signup-pt-1
branch
from
32bcfee
to
b6a72ab
Compare
- Munge Fix sql query output - Text:: don't do week in seconds. - Fix: hide exact task delivery on signup - Add: note about over-querying db. - Switch "Campaign filled" button to :secondary color. - Fix typo. - Fix: use replace with patch for rider signup links.
teesloane
force-pushed
the
140-rider-campaign-signup-pt-1
branch
from
7e1bab8
to
5f3ca19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140. Commits are atomic and go into more detail.
CleanShot.2023-12-11.at.19.32.52-converted.mp4