258: Enable editing campaign riders #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With these changes, we explicitly expect that selected_rider is an attr on the <.rider_select> component, and then pass that on toe the RiderSelectionComponent. No implementation changes necessary as `selected_rider` can be nil
At the bottom of the file there was a handle_event match for `add_rider` that caught all params; however this was never being caught as the original `add_rider` that matches first wasn't checking for a missing rider_id.
This was probably brought in from branching off of #251
teesloane
force-pushed
the
258-edit-rider
branch
from
86eecf6
to
06a33b6
Compare
teesloane
changed the title
mveytsman
requested changes
Dec 18, 2023
|
Fixed and ready for re-review! |
mveytsman
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #258
This set of commits makes the following changes:
mount.)Screencap of the changes
CleanShot.2023-11-15.at.09.51.22.mp4