Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: mobile styling for campaign modal #252

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

teesloane
Copy link
Contributor

@teesloane teesloane commented Oct 30, 2023

Fixes #153 and #156

  • shrink modal padding on mobile to have more space
  • change campaign dates into a column on mobile
  • change live location picker to put fields into columns on mobile

#153 refers to the mobile nav covering the modal, but I don't think this is happening anymore.

Screenshots

Before After
Screen Shot 2023-10-30 at 06 02 08 Screen Shot 2023-10-29 at 17 54 06
Screen Shot 2023-10-30 at 06 02 18 Screen Shot 2023-10-30 at 06 02 38

- also, shrink modal padding on mobile to have more space
- change campaign dates into a column on mobile
- change live location picker to put fields into columns on mobile
Copy link
Member

@mveytsman mveytsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@teesloane teesloane merged commit d3e7fef into main Nov 7, 2023
1 check passed
@teesloane teesloane deleted the 153-campaign-modal-mobile branch November 7, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile improvements to Edit Campaign modal
2 participants