-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Itinerary page #251
Add: Itinerary page #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit: let's switch to the :for
syntax as we work on the templates
Ready for re-review! |
This was probably brought in from branching off of #251
This was probably brought in from branching off of #251
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Add: CampaignRider Edit form. * [wip] Pre-selecting rider. * Pass selected rider to RiderSelectionComponent With these changes, we explicitly expect that selected_rider is an attr on the <.rider_select> component, and then pass that on toe the RiderSelectionComponent. No implementation changes necessary as `selected_rider` can be nil * Remove no longer needed handle_event "add_rider" * Test: editing of campaign rider. * Fix: flash on missing rider_id At the bottom of the file there was a handle_event match for `add_rider` that caught all params; however this was never being caught as the original `add_rider` that matches first wasn't checking for a missing rider_id. * Fix: compiler warning. * Refactor: rename AddRiderFormComponent * Fix: don't jump to profile on rider login This was probably brought in from branching off of #251 * Make request changes.
I thought there would be more to do in building the itinerary page, but I think a lot of it was already done.
This PR adds:
/itinerary
route.If I understand correctly, this maybe closes #136?