come current with upstream/master so we can bump stdlib #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is the lowest supported version for ensure_packages
this is a private class, it won't get called directly, only from within the main class. It references variables from the main class, so we need to include it (or move the tests into the testfile for the main class)
Add PHP 7.1 support on Debian
…ency fix composer auto_update idempotency in case no update is available
add ubuntu 16.04 support
modulesync 1.7.0
this fixes an error that was introduced in 0ad7566
use correct require arguments
modulesync 1.8.0
release 5.2.0
Add Acceptance tests
software-properties-common is needed to add ppas on ubuntu. the puppetlabs-apt module can manage the package. it is save to enable this, because the module uses ensure_package: https://github.com/puppetlabs/puppetlabs-apt/blob/df40baebedf5c0c15e08f3ec78adfd760b1371ca/manifests/ppa.pp#L30 Without this, managing ppa repos at least on ubuntu 16.04 is impossible. I noticed this bug while testing with aceptance tests in voxpupuli#418
manage software-properties-common on ubuntu
add examples for php-fpm/nginx
Fix Archlinux support
remove www pool from defaults
Cleanup fpm config class
modulesync 3.0.0 & puppet-lint autofix
this is a dependency from the apt module. we need to pull it in.
Drop EOL Debian 7/8 & Ubuntu 12/14
Some configuration options (e.g. 'listen_owner', 'listen_group', 'listen_mode', and maybe some more) do not apply by reloading 'php-fpm.service' but require a proper restart.
(voxpupuli#596) drop 'reload' in favour of 'restart'
Signed-off-by: Simon Deziel <[email protected]>
Add apparmor_hat support to php::fpm::pool
By default, this module uses a reload for the php-fpm service. This is nice because it ensures that there is no downtime. But this is also bad because certain configuration options, like unix socket owner/group will only be changed during a restart. Fixes: voxpupuli#596 Replaces: voxpupuli#597
php-fpm: Make service reload/restart configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why
We rely on @mhagstrand's addition to this module — 36fe9f6 — which still has an open/un-merged upstream MR — voxpupuli#511. In my effort to bump up our
puppetlabs-stdlibversion this change brings up up to the currentmasterfrom https://github.com/voxpupuli/puppet-php and pulls in that change.Impact
This newer module version will not be used I merge this MR and update the ref in our
Puppetfile/Puppetfile.lockfiles in our puppet repo