Flag to enable email as a fallback identifyer. Solution to issue #5872 #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, |
farhatahmad
approved these changes
Sep 16, 2024
|
I'll merge this and fix rubocop in a separate PR |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
As discussed in issue #5872, there are various pros and cons to using email as a fallback identifier.
As some setups depend on it, I have implemented a flag to enable the old behaviour of using email as a fallback identifier. Setting USE_EMAIL_AS_EXTERNAL_ID_FALLBACK=true will cause greenlight to behave as it did before the fallback was removed, which is important for the operation of some systems migrated from version 2, and others with users that existed before the use of an IDP.
If you have any questions, please ask.