Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ApiParameterMapper-Attribute Class #253

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

DigitalTimK
Copy link
Contributor

@DigitalTimK DigitalTimK commented May 6, 2024

This PR will:

  • push the array-generation inside of getHTTPQuery() into a separate toArray()-function
  • introduce ApiParameterMapper-AttributeClass (new php8 feature), using at the getter of each parameter values to generate the former data array (see toArray()-function) automatically with toApiDataArray()-function.
  • adapt getHttpQuery()-function to use new toApiDataArray()-function instead of toArray()-function
  • set toArray()-function as deprecated (shall be removed once new concept is bullet prove)
  • implement temporary test to ensure toArray()-function and toApiDataArray()-function deliver identical content

While working on the parameter generation this PR will improve in addition:

  • MetaParameters-class
  • UserDataParameters-class

@DigitalTimK DigitalTimK changed the title Introduce BbbApiMapper-Attribute Class Introduce ApiParameterMapper-Attribute Class May 6, 2024
@GhaziTriki GhaziTriki added the enhancement Improvement or addition to existing functionality label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or addition to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants