Skip to content

Update method names and clean #1175

Update method names and clean

Update method names and clean #1175

Triggered via push September 21, 2024 20:16
Status Success
Total duration 25m 26s
Artifacts 8

CI_master.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 71 warnings
Lint / Lint
Process completed with exit code 1.
Lint / Lint
Process completed with exit code 1.
Lint / Lint: src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py#L1
would reformat src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py
Lint / Lint: src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py#L468
TODO: addConstraint(constraint) triggers a solve (for godd reasons) however, this way (fixme)
Lint / Lint: src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py#L707
TODO: can we get the solver's messages somehow to improve the message? (fixme)
Lint / Lint: src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py#L1
Missing module docstring (missing-module-docstring)
Lint / Lint: src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py#L24
Multiple imports on one line (FreeCAD, os, sys, unittest, Part, Sketcher) (multiple-imports)
Lint / Lint: src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py#L37
Missing function or method docstring (missing-function-docstring)
Lint / Lint: src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py#L79
Missing function or method docstring (missing-function-docstring)
Lint / Lint: src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py#L87
Missing function or method docstring (missing-function-docstring)
Lint / Lint: src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py#L126
Missing function or method docstring (missing-function-docstring)
Lint / Lint: src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py#L168
Missing function or method docstring (missing-function-docstring)
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L58
Include the directory when naming header files [build/include_subdir] [4]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L68
Lines should be <= 120 characters long [whitespace/line_length] [2]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L75
Lines should be <= 120 characters long [whitespace/line_length] [2]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L86
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L89
Tab found; better to use spaces [whitespace/tab] [1]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L96
Tab found; better to use spaces [whitespace/tab] [1]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L97
Tab found; better to use spaces [whitespace/tab] [1]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L98
Tab found; better to use spaces [whitespace/tab] [1]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L99
Tab found; better to use spaces [whitespace/tab] [1]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L100
Tab found; better to use spaces [whitespace/tab] [1]
Lint / Lint
NCollection_ListNode has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
Lint / Lint
Pass small and trivially-copyable type by value (const class NCollection_BaseList::Iterator &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class NCollection_BaseList::Iterator &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L66
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L67
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L68
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L69
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L70
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L71
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L75
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L76
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L77
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
Lint / Lint: src/Mod/PartDesign/App/FeatureHole.cpp#L85
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(352): conda version: 24.7.1
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(353): conda-libmamba-solver version: 24.7.0
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(354): libmambapy version: 1.5.9
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(355): Target prefix: '/Users/runner/work/FreeCAD/FreeCAD/.conda/freecad' INFO conda.conda_libmamba_solver.solver:_log_info(356): Command: ['/Users/runner/miniconda3/condabin/mamba', 'update', '--prefix', '.conda/freecad', '--file', 'conda/conda-env.yaml']
MacOS_13_Conda_Apple / Build
info libmamba Reading repodata.json file "/var/folders/0g/hj_q_pzx65bbjnslxz9n0src0000gn/T/tmp0tfci1y9.json" for repo installed
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 0 bytes {'User-Agent': 'conda/24.7.1 requests/2.32.3 CPython/3.12.5 Darwin/23.6.0 OSX/14.6.1 solver/libmamba conda-libmamba-solver/24.7.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches 5fef5ecd58e910a9… → 5fef5ecd58e910a9…
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 716196 bytes {'User-Agent': 'conda/24.7.1 requests/2.32.3 CPython/3.12.5 Darwin/23.6.0 OSX/14.6.1 solver/libmamba conda-libmamba-solver/24.7.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches 2536d904f6add4e4… → 2536d904f6add4e4…
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 2050706 bytes {'User-Agent': 'conda/24.7.1 requests/2.32.3 CPython/3.12.5 Darwin/23.6.0 OSX/14.6.1 solver/libmamba conda-libmamba-solver/24.7.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(352): conda version: 24.7.1 INFO conda.conda_libmamba_solver.solver:_log_info(353): conda-libmamba-solver version: 24.7.0
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(354): libmambapy version: 1.5.9
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(355): Target prefix: '/home/runner/work/FreeCAD/FreeCAD/.conda/freecad'
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(356): Command: ['/home/runner/miniconda3/condabin/mamba', 'update', '--prefix', '.conda/freecad', '--file', 'conda/conda-env.yaml']
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 716196 bytes {'User-Agent': 'conda/24.7.1 requests/2.32.3 CPython/3.12.5 Linux/6.8.0-1014-azure ubuntu/22.04.5 glibc/2.35 solver/libmamba conda-libmamba-solver/24.7.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches 2536d904f6add4e4… → 2536d904f6add4e4…
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 1613518 bytes {'User-Agent': 'conda/24.7.1 requests/2.32.3 CPython/3.12.5 Linux/6.8.0-1014-azure ubuntu/22.04.5 glibc/2.35 solver/libmamba conda-libmamba-solver/24.7.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches c5cc347082717df0… → c5cc347082717df0…
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 2050706 bytes {'User-Agent': 'conda/24.7.1 requests/2.32.3 CPython/3.12.5 Linux/6.8.0-1014-azure ubuntu/22.04.5 glibc/2.35 solver/libmamba conda-libmamba-solver/24.7.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches c25462d7872987b0… → c25462d7872987b0…
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(352): conda version: 24.7.1
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(353): conda-libmamba-solver version: 24.7.0
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(354): libmambapy version: 1.5.9
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(355): Target prefix: '/home/runner/work/FreeCAD/FreeCAD/.conda/freecad'
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(356): Command: ['/home/runner/miniconda3/condabin/mamba', 'update', '--prefix', '.conda/freecad', '--file', 'conda/conda-env-qt6.yaml']
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 716196 bytes {'User-Agent': 'conda/24.7.1 requests/2.32.3 CPython/3.12.5 Linux/6.8.0-1014-azure ubuntu/22.04.5 glibc/2.35 solver/libmamba conda-libmamba-solver/24.7.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches 2536d904f6add4e4… → 2536d904f6add4e4…
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 1613518 bytes {'User-Agent': 'conda/24.7.1 requests/2.32.3 CPython/3.12.5 Linux/6.8.0-1014-azure ubuntu/22.04.5 glibc/2.35 solver/libmamba conda-libmamba-solver/24.7.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches c5cc347082717df0… → c5cc347082717df0…
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 2050706 bytes {'User-Agent': 'conda/24.7.1 requests/2.32.3 CPython/3.12.5 Linux/6.8.0-1014-azure ubuntu/22.04.5 glibc/2.35 solver/libmamba conda-libmamba-solver/24.7.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}

Artifacts

Produced during runtime
Name Size
Lint-10975376117-Logs
29.7 KB
MacOS_13_Conda_Apple-10975376117-Logs
44.8 KB
Prepare-10975376117-Logs
4.08 KB
Ubuntu_20-04-10975376117-Logs
178 KB
Ubuntu_22-04_Conda-10975376117-Logs
240 KB
Ubuntu_22-04_Conda-Qt6-10975376117-Logs
238 KB
Ubuntu_22-04_Conda-Qt6-10975376117-report.md
3.76 KB
Windows-10975376117-Logs
1.63 MB