Support macros and console logs in Assembly #1171
Annotations
14 errors and 36 warnings
Check for trailing whitespaces
Process completed with exit code 1.
|
Black (Python)
Process completed with exit code 1.
|
Pylint:
src/Mod/Assembly/CommandCreateAssembly.py#L58
Possibly using variable 'Gui' before assignment (possibly-used-before-assignment)
|
Pylint:
src/Mod/Assembly/CommandCreateBom.py#L95
Possibly using variable 'Gui' before assignment (possibly-used-before-assignment)
|
Pylint:
src/Mod/Assembly/CommandCreateBom.py#L99
Possibly using variable 'QtCore' before assignment (possibly-used-before-assignment)
|
Pylint:
src/Mod/Assembly/CommandCreateBom.py#L107
Possibly using variable 'QtWidgets' before assignment (possibly-used-before-assignment)
|
Pylint:
src/Mod/Assembly/CommandCreateJoint.py#L61
Possibly using variable 'Gui' before assignment (possibly-used-before-assignment)
|
Pylint:
src/Mod/Assembly/CommandCreateView.py#L77
Possibly using variable 'Gui' before assignment (possibly-used-before-assignment)
|
Pylint:
src/Mod/Assembly/CommandCreateView.py#L453
Possibly using variable 'QtCore' before assignment (possibly-used-before-assignment)
|
Pylint:
src/Mod/Assembly/CommandCreateView.py#L476
Possibly using variable 'QMenu' before assignment (possibly-used-before-assignment)
|
Pylint:
src/Mod/Assembly/CommandExportASMT.py#L77
Possibly using variable 'Gui' before assignment (possibly-used-before-assignment)
|
Pylint:
src/Mod/Assembly/CommandInsertLink.py#L82
Possibly using variable 'Gui' before assignment (possibly-used-before-assignment)
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax)
Process completed with exit code 1.
|
Cpplint
Process completed with exit code 1.
|
Check for trailing whitespaces:
src/Mod/Part/Gui/TaskSweep.cpp#L202
if (!shape.Infinite() && <-- trailing whitespace
|
Black (Python):
src/Ext/freecad/module_io.py#L1
would reformat src/Ext/freecad/module_io.py
|
Black (Python):
src/Mod/Assembly/CommandCreateAssembly.py#L1
would reformat src/Mod/Assembly/CommandCreateAssembly.py
|
Black (Python):
src/Mod/Assembly/CommandExportASMT.py#L1
would reformat src/Mod/Assembly/CommandExportASMT.py
|
Black (Python):
src/Mod/Assembly/CommandCreateBom.py#L1
would reformat src/Mod/Assembly/CommandCreateBom.py
|
Black (Python):
src/Mod/Assembly/CommandCreateJoint.py#L1
would reformat src/Mod/Assembly/CommandCreateJoint.py
|
Black (Python):
src/Mod/Assembly/CommandSolveAssembly.py#L1
would reformat src/Mod/Assembly/CommandSolveAssembly.py
|
Black (Python):
src/Mod/Assembly/CommandInsertLink.py#L1
would reformat src/Mod/Assembly/CommandInsertLink.py
|
Black (Python):
src/Mod/Assembly/CommandCreateView.py#L1
would reformat src/Mod/Assembly/CommandCreateView.py
|
Black (Python):
src/Mod/Assembly/UtilsAssembly.py#L1
would reformat src/Mod/Assembly/UtilsAssembly.py
|
Black (Python):
src/Mod/Assembly/JointObject.py#L1
would reformat src/Mod/Assembly/JointObject.py
|
Pylint:
src/Ext/freecad/module_io.py#L1
Missing module docstring (missing-module-docstring)
|
Pylint:
src/Ext/freecad/module_io.py#L1
Missing function or method docstring (missing-function-docstring)
|
Pylint:
src/Mod/Assembly/CommandCreateAssembly.py#L52
Line too long (150/100) (line-too-long)
|
Pylint:
src/Mod/Assembly/CommandCreateAssembly.py#L1
Missing module docstring (missing-module-docstring)
|
Pylint:
src/Mod/Assembly/CommandCreateAssembly.py#L31
Import "import UtilsAssembly" should be placed at the top of the module (wrong-import-position)
|
Pylint:
src/Mod/Assembly/CommandCreateAssembly.py#L32
Import "import Preferences" should be placed at the top of the module (wrong-import-position)
|
Pylint:
src/Mod/Assembly/CommandCreateAssembly.py#L41
Missing class docstring (missing-class-docstring)
|
Pylint:
src/Mod/Assembly/CommandCreateAssembly.py#L57
Missing function or method docstring (missing-function-docstring)
|
Pylint:
src/Mod/Assembly/CommandCreateAssembly.py#L69
Missing function or method docstring (missing-function-docstring)
|
Pylint:
src/Mod/Assembly/CommandCreateBom.py#L74
Line too long (176/100) (line-too-long)
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax):
src/Gui/Application.cpp#L2291
QTimer::singleShot(0, &mw, SLOT(delayedStartup())); <--Consider using Functor-Based Connections
|
Cpplint:
src/App/Application.cpp#L33
At least two spaces is best between code and comments [whitespace/comments] [2]
|
Cpplint:
src/App/Application.cpp#L131
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
Cpplint:
src/App/Application.cpp#L136
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
Cpplint:
src/App/Application.cpp#L137
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
Cpplint:
src/App/Application.cpp#L138
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
Cpplint:
src/App/Application.cpp#L140
At least two spaces is best between code and comments [whitespace/comments] [2]
|
Cpplint:
src/App/Application.cpp#L141
Extra space after ( in function call [whitespace/parens] [4]
|
Cpplint:
src/App/Application.cpp#L147
At least two spaces is best between code and comments [whitespace/comments] [2]
|
Cpplint:
src/App/Application.cpp#L148
At least two spaces is best between code and comments [whitespace/comments] [2]
|
Cpplint:
src/App/Application.cpp#L154
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Clazy
fatal error: 'Build/Version.h' file not found
|
Clazy:
src/Base/TimeInfo.h#L70
Pass small and trivially-copyable type by value (const class Base::TimeInfo &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/TimeInfo.h#L70
Pass small and trivially-copyable type by value (const class Base::TimeInfo &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/TimeInfo.h#L76
Pass small and trivially-copyable type by value (const class Base::TimeInfo &) [-Wclazy-function-args-by-value]
|
Loading