Add config option for sending different rating values to SPADS #512
Conversation
Name is highly confusing, but I don't quite know what else to name it.
| @@ -1030,6 +1030,61 @@ defmodule Teiserver.Account do | |||
| Repo.delete(rating) | |||
| end | |||
|
|
|||
| @doc """ | |||
| Returns the player's rank when compared to other players by rating. | |||
|
|
|||
There was a problem hiding this comment.
In teiserver "rank" means their chevron level indexed at 0. So we have to be careful here since you are using the term "rank" in a different way. Perhaps add a comment that this is ranking relative to other players completely unrelated to chevron levels. In teiserver db, the rank of a user relates to chev levels.
There was a problem hiding this comment.
Used "position" instead. It's a struggle coming up with the best name - let me know if you can think of any better alternatives.
|
Currently with this PR, it is up to the Admin to change the config and this would affect all lobbies. I have a feeling that you'd get pushback from some people to hide the rating in all lobbies. I think it's worth discussing in discord to see how receptive people would be to this option. Should it affect all lobbies? Or just some where the boss wants it? If the latter would that cause confusion? Showing someone's relative position to others also means you have to sort the rating table which is an additional cost that wasn't there before. Was Teifion's intention to show a number based on relative position in lobby or relative to the playerbase as a whole? Because the latter is a much bigger sort. Showing position relative to the lobby is much more anonymous which I believe is the intention. If you're showing the relative position compared to the whole playerbase you might as well just show the rating. |
Addresses #149