Add matchmaking/cancelled event #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekingfrog
force-pushed
the
add-cancelled
branch
from
7a9fcdb
to
153bf9d
Compare
Jazcash
reviewed
Sep 12, 2024
src/schema/matchmaking/cancelled.ts
Outdated
| "Server may send this event at any point when the user is queuing to indicate that the user has been booted out the matchmaking system.", | ||
| event: { | ||
| data: Type.Object({ | ||
| reason: Type.String(), |
There was a problem hiding this comment.
I'd like to try and keep properties like this as explicit as possible where we can, unless it really doesn't make sense. For example, here I would change Type.String() to Type.Union([ Type.Literal("intentional"), Type.Literal("party_user_left"), Type.Literal("server_playlists_changed") ]). If we need to add or remove reasons later we can easily do so, but this approach improves the typing for protocol consumers and makes it easy for client devs to see what possible reasons to expect here.
There was a problem hiding this comment.
And for any free form text there can be additional details field as in responses
There was a problem hiding this comment.
Amended the commit to hardcode some reasons.
Jazcash
approved these changes
Sep 12, 2024
geekingfrog
force-pushed
the
add-cancelled
branch
from
153bf9d
to
af7f5cf
Compare
geekingfrog
force-pushed
the
add-cancelled
branch
from
af7f5cf
to
6684ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an event to boot a player out of matchmaking. 2 reasons I can see where this is needed: