Fixed opening of links in an external app.

[mikeller]

Fixes #1980.

Open the app Window as a NW.js window, which is what NW.js was designed for.
This will re-enable the new-win-policy NW.js event handler that is required to open links in an external app.

Also moves the close handler into main.js, so that eventPage.js does not need to be used in NW.js any more.

[McGiverGim]

Is good to me, good fix @mikeller! I tried to do something similar yesterday but I suppose I did something wrong 🤪

[mikeller]

@McGiverGim: It was a lot of trial and error. 😅

[Docteh]

What about the minimum size of the window? I like the dark task bar on windows 10, its probably respecting dark mode now.

  "window": {
    "show": false,
    "icon": "images/bf_icon_128.png",
    "id": "main-window",
    "min_height": 550,
    "min_width": 1024
  },

[McGiverGim]

True, we have a lot of tabs and css working for this minimum sizes. Maybe when merged the Cordova PR it adjust better, but for this release I think is better to have it.

[Docteh]

@McGiverGim This innerBounds section not being effective is what I'm talking about with the min_width/min_height suggestion.

[McGiverGim]

Maybe we must try to open the window from JavaScript and pass them as parameters, similar to the Chrome version.
My PR opened it from JavaScript but I have not passed parameters.

[mikeller]

@Docteh: Sorry, my bad. I simply copied the window settings from eventPage.js without verifying that they are actually in the correct format for NW. Fixed now - seems to be working fine.

[TheIsotopes]

@mikeller i tested this and found a bug
in cli tab the buttons load from file and save to file does not work.

EDIT:
in firmware flasher tab the button load firmware (local) also not working.

EDIT again:
all buttons with local load and save function does not working.

[McGiverGim]

Maybe we are using chrome load/save features and not nw features?

[McGiverGim]

I confirm:

betaflight-configurator/src/js/tabs/cli.js

Line 142 in 433fe20

chrome.fileSystem.chooseEntry({type: 'saveFile', suggestedName: filename, accepts: accepts}, function(entry) {

and I suppose we must use: https://nwjs.readthedocs.io/en/nw13/References/File%20Dialogs/

Maybe we must make a wrapper similar to the one of Clipboard.js

[McGiverGim]

It seems that since nw2, as we suspected, the window opened from the background page is treated as a background page. This is the error when trying to open a file:

So the problem starts here...

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
1 Code Smell

No Coverage information
1.0% Duplication

[mikeller]

From the look of it this goes deeper than what we are doing with the clipboard - without the Chrome filesystem API we'll have to use the node filesystem module, and with this we'll have to move to requiring modules.
I have disabled NW2 for now - the scope of moving to NW2 seems to be too big and risky to do before the upcoming release.

Confirmed working:

• loading links in an external browser;
• opening files.

[TheIsotopes]

confirmed, working again 👍

[McGiverGim]

Yes, it has a lot of sense to disable nw2 for this release.

[mikeller]

@MaximeAmadasi: You should probably be aware of this, as it changes some of the underlying code that you are working on as well, so you can rebase on this as soon as it has been merged.

[WalcoFPV]

True, we have a lot of tabs and css working for this minimum sizes. Maybe when merged the Cordova PR it adjust better, but for this release I think is better to have it.

The cordova PR will make the headerbar a flex container. It's design to work with a miminum window width of 1024px. And when the window width is below 575px, it switchs to the mobile headerbar (which is the same header bar but more compact)