-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance offline connection handling #423
Conversation
I've implemented the optional automatic disconnection feature as discussed. Here's a screenshot of the new setting in the app: This addition allows users to choose whether they want the VPN to automatically disconnect when internet connection is lost. If you'd prefer, I can submit these changes as a new commit. Let me know if you'd like me to proceed with that or if you have any other feedback or suggestions. |
Thank you for your contribution. When a user is using mobile data via Hotspot, their internet connection may frequently disconnect and reconnect momentarily. However, the Warp-plus connection remains stable without the need to reconnect. This also applies when the OS is in Sleep mode for extended periods, and the connection generally does not drop. The connection only actually disconnects when Warp-plus notifies Oblivion Desktop that the connection has been lost, triggering the wp-end method. However, we recommend that you participate in the following issue related to the kill switch, if you are interested: #176 |
@ircfspace Thank you for your efforts in promoting free internet access. |
@ShadowZagrosDev Do you mean that when you are connected and go offline, it's not possible to disconnect either from the System Tray or from the main app page? If that's what you're referring to, we can review and fix this issue in pages/Landing. Regarding SpeedTest, yes, we have something similar to what you've shown in the screenshot in mind, but is the data from your feature as reliable as SpeedTest? Additionally, can it include issue #132 to display details alongside the IP and ping (after connection)? |
@ircfspace I hadn't checked the System Tray option before, but I've verified now that disconnection is possible there. I had only tested the switch, though it would be beneficial if disconnection could be done through that as well. |
@ShadowZagrosDev Yes, the intention was to display real-time speed. Thanks in advance. |
@ircfspace |
Improve connection handling when user goes offline
Currently, the connection switch is disabled when offline, even if the VPN is connected. This change allows users to disconnect manually when they lose internet connection while the VPN is active.
A commented line for auto-disconnect on connection loss is currently disabled to avoid kill-switch-like behavior. When enabled, it automatically disconnects the VPN, which won't reconnect when internet is restored. Consider implementing this as a configurable option in the app settings, allowing users to choose whether they want automatic disconnection or to stay connected for when internet returns.