Fix compatibility with Global ID (#1064)

bensheldon · Sep 2, 2023 · 1ee5368 · 1ee5368
1 parent f6e8270
commit 1ee5368
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/app/models/good_job/batch.rb b/app/models/good_job/batch.rb
@@ -59,6 +59,10 @@ def self.enqueue(active_jobs = [], **properties, &block)
       end
     end
 
+    def self.primary_key
+      :id
+    end
+
     def self.find(id)
       new _record: BatchRecord.find(id)
     end

diff --git a/spec/app/models/good_job/batch_spec.rb b/spec/app/models/good_job/batch_spec.rb
@@ -15,6 +15,16 @@ def perform(batch, params)
     end)
   end
 
+  it 'is a valid GlobalId' do
+    batch = described_class.new
+    batch.save
+
+    global_id = batch.to_global_id
+    returned_batch = GlobalID::Locator.locate(global_id)
+
+    expect(returned_batch.id).to eq batch.id
+  end
+
   describe '.enqueue' do
     it 'creates a batch' do
       batch = described_class.enqueue do