Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JAXopt solvers #46

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add JAXopt solvers #46

wants to merge 5 commits into from

Conversation

mblondel
Copy link

@mblondel mblondel commented Jul 4, 2023

No description provided.

tomMoral
tomMoral reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Just a comment to make the solver importable even without jax installed.

solvers/jaxopt.py Outdated Show resolved Hide resolved
solvers/jaxopt.py Outdated Show resolved Hide resolved
@agramfort
Copy link
Contributor

@mblondel I approved CIs but you have flake8 issues

@mblondel
Copy link
Author

mblondel commented Jul 5, 2023

You need to approve to re-run CI.

@agramfort
Copy link
Contributor

seems to be a float32 issue on macos https://github.com/benchopt/benchmark_logreg_l2/actions/runs/5462697835/jobs/9944802533?pr=46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomMoral tomMoral tomMoral left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mblondel @agramfort @tomMoral