Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behaviour when sending email to non-existent voter_id #380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cryptosaurus
Copy link

No description provided.

@Cryptosaurus
Copy link
Author

Proposed fix for #381

@shirlei
Copy link
Contributor

shirlei commented May 10, 2023

@Cryptosaurus @benadida I'm in the middle of a major update with Adida's upstream, and I'm facing or have faced some issues like this one. This situation in particular is due to some recent changes. When the uploaded voters are not the 'traditional' password type, a user is created and the voter points to that user, without having a voter_login_id (used by the method get_by_election_and_voter_id as a filter). I've opted for a different solution instead of throwing an error, since there is usually an email for that voter and the auth system knows later how to get that email in the send_message method. I've changed the listing in question to use the actual voter.id, which allows to retrieve the voter and then later the auth system deals with sending retrieving and sending the email for that specific voter. If you're interested in checking it (it is in a working branch, specific for the self-hosted installation, so there are some changes not specifically related to this upstream), here is the link: shirlei@298a458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants