Fix bug when removing password voter #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voter.user is virtual for users of type password
|
Proposed fix for #379 |
|
@Cryptosaurus @benadida this seemed familiar to me and checking my fork I see that I ran into the same issue a while back and this is exactly what I did. My guess is that this use case isn't used a lot, but I think this PR would be nice to be accepted. |
|
I don't know how common this use-case is, but for my usage it would be a nice feature, and there is clearly an intention to support it in the current code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
voter.user is virtual for users of type password