ya-share2, move yashare, bem-contrib #74
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| { | ||
| "name": "bem-social", | ||
| "version": "0.3.2", | ||
| "description": "BEM Social Components Library", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git://github.com/bem-contrib/bem-social" | ||
| }, | ||
| "keywords": [ | ||
| "bem", | ||
|
|
@@ -24,7 +24,7 @@ | |
| "Ivan Voischev <[email protected]>" | ||
| ], | ||
| "dependencies": { | ||
| "bem-components": "^2.3.0" | ||
| }, | ||
| "license": "MIT" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| block('yashare')( | ||
| js()(true), | ||
| cls()('ya-share2'), | ||
| attrs()(function() { | ||
| var ctx = this.ctx, | ||
| attrs = { | ||
| 'data-bare' : ctx.bare, | ||
| 'data-counter' : ctx.counter, | ||
| 'data-copy' : ctx.copy, | ||
| 'data-description' : ctx.description, | ||
| 'data-image' : ctx.image, | ||
| 'data-lang' : ctx.lang, | ||
| 'data-limit' : ctx.limit, | ||
| 'data-services' : (ctx.services || []).join(','), | ||
| 'data-size' : ctx.size, | ||
| 'data-title' : ctx.title, | ||
| 'data-url' : ctx.url, | ||
| }; | ||
| return attrs; | ||
| }) | ||
| ); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| module.exports = function(bh) { | ||
|
|
||
| bh.match('yashare', function(ctx, json) { | ||
| ctx.js(true); | ||
|
There was a problem hiding this comment. методы ctx
.js(true)
.cls('ya-share2')
.attrs(); |
||
| ctx.cls('ya-share2'); | ||
| ctx.attrs({ | ||
| 'data-bare' : json.bare, | ||
| 'data-counter' : json.counter, | ||
| 'data-copy' : json.copy, | ||
| 'data-description' : json.description, | ||
| 'data-image' : json.image, | ||
| 'data-lang' : json.lang, | ||
| 'data-limit' : json.limit, | ||
| 'data-services' : (json.services || []).join(','), | ||
| 'data-size' : json.size, | ||
| 'data-title' : json.title, | ||
| 'data-url' : json.url, | ||
| }); | ||
| }); | ||
|
|
||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| [{ | ||
| block : 'yashare' | ||
| }, { | ||
| block : 'yashare', | ||
| services : ['a,b,c'], | ||
|
There was a problem hiding this comment. тут точно не должно быть |
||
| }] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| <div class="yashare i-bem ya-share2" data-services="" data-bem="{"yashare":{}}"></div> | ||
| <div class="yashare i-bem ya-share2" data-services="a,b,c" data-bem="{"yashare":{}}"></div> |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -378,13 +378,12 @@ | |
| 'moimir', | ||
| 'gplus' | ||
| ], | ||
| url : 'http://bem-incubator.github.io/bem-social/', | ||
| title : 'BEM Social Components Library', | ||
| description : 'Fork me on GitHub', | ||
| image : 'https://raw.githubusercontent.com/voischev/bem-social/' + | ||
| 'master/desktop.bundles/index/blocks/page/image/bem.png', | ||
| counter : true | ||
| }, | ||
| { | ||
| tag : 'br' | ||
|
|
@@ -401,37 +400,33 @@ | |
| 'friendfeed', | ||
| 'gplus' | ||
| ], | ||
| url : 'http://bem-incubator.github.io/bem-social/', | ||
| title : 'BEM Social Components Library', | ||
| description : 'Fork me on GitHub', | ||
| image : 'https://raw.githubusercontent.com/voischev/bem-social/' + | ||
| 'master/desktop.bundles/index/blocks/page/image/bem.png', | ||
| limit : 4, | ||
| copy : 'last' | ||
|
|
||
| }, | ||
| { | ||
| tag : 'br' | ||
| }, | ||
| { | ||
| block : 'yashare', | ||
| quickServices : [ | ||
|
There was a problem hiding this comment. Оставить поддержку поля quickServices, которое в новом api просто services, или тоже вырезать? There was a problem hiding this comment. @adinvadim думаю двигаться нужно на упрощение) так что вырезай |
||
| 'vkontakte', | ||
| 'facebook', | ||
| 'twitter', | ||
| 'odnoklassniki', | ||
| 'lj' | ||
| ], | ||
| url : 'http://bem-incubator.github.io/bem-social/', | ||
| title : 'BEM Social Components Library', | ||
| description : 'Fork me on GitHub', | ||
| image : 'https://raw.githubusercontent.com/voischev/bem-social/' + | ||
| 'master/desktop.bundles/index/blocks/page/image/bem.png', | ||
| size : 's' | ||
| } | ||
| ] | ||
| }, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
кмк, либо дописать еще один
var, либо отбить все объявление вправо.но вообще предлагаю что-нибудь типа: