Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix union use in utils.py & add tox GitHub workflow #35

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

jordan-gillard
Copy link
Contributor

This PR fixes a Python 3.9 incompatible type annotation in utils.py. It also adds tox to build the project and run a basic test using Python versions 3.9, 3.10, 3.11, and 3.12. I added a GitHub workflow as well to run these checks in CI. This will keep Python 3.9 incompatible changes from being reintroduced in the future.

Resolves: #32
Relates to: #11

@jordan-gillard jordan-gillard changed the title Fix union use in utils.py & add tox GitHub workflow (#32) Fix union use in utils.py & add tox GitHub workflow Jul 7, 2024
@jordan-gillard
Copy link
Contributor Author

@GalenReich @andy-seleya
ezgif-7-c7d7904d81

@GalenReich GalenReich self-requested a review July 8, 2024 15:35
Copy link
Collaborator

@GalenReich GalenReich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordan-gillard you are my hero

I have some best practice questions about when is a good time to increment version numbers (I am notionally trying to stick to semver but feel I probably increment the patch number too frequently)... any advice?

@GalenReich
Copy link
Collaborator

Ooh, maybe we should add a line to the README, something like:

# Run the tests
poetry run tox

@jordan-gillard
Copy link
Contributor Author

Ooh, maybe we should add a line to the README, something like:

# Run the tests
poetry run tox

Ooo yeah, good call. Updated in c7752c1

@jordan-gillard
Copy link
Contributor Author

I have some best practice questions about when is a good time to increment version numbers (I am notionally trying to stick to semver but feel I probably increment the patch number too frequently)... any advice?

Haha honestly we're both on the same page. I just try to use the Semver 2.0.0 Standard as best I can. Also, it's totally fine to frequently increment the patch version. That's how it should work :)

I have used tools in the past that automatically bump project versions but I never felt it was worth it. I'd say for now it's okay to just do it manually as best we can. For a small project like this one with only a few maintainers, manual updates are probably best.

@GalenReich GalenReich merged commit 20c5d58 into bellingcat:main Jul 9, 2024
4 checks passed
@jordan-gillard jordan-gillard deleted the add-tox branch July 9, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Union Type is added in Python 3.10
2 participants