Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Adding file/bytes parameter API support. #133

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hazmat345
Copy link
Contributor

These changes are for the API only. The UI has not been done yet.
We are only supporting gridfs for now, but these changes do allow
for file uploads as well as file streaming download.

These changes are for the API only. The UI has not been done yet.
We are only supporting gridfs for now, but these changes do allow
for file uploads as well as file streaming download.
@hazmat345 hazmat345 changed the title Adding file/bytes parameter API support. WIP Adding file/bytes parameter API support. Jun 5, 2019
@hazmat345
Copy link
Contributor Author

I think if we're going to support file parameters the api should be v1, not vbeta.

@hazmat345
Copy link
Contributor Author

I was able to exercise the example plugin without having to jump through too many hoops. I used the swagger API to upload the file to get the parameter dictionary.

I modified the angular-schema-form-builder so that bytes parameters are rendered as dictionary widgets, and then pasted the parameter dictionary in there, and everything Just Worked. Super cool!

@loganasherjones
Copy link
Member

I think the file upload API should be in vbeta until we have seen it in use for some amount of time. Ideally, we won't have to change it, but I don't think we've ever dealt with relatively large parameters before and I'm not sure where the edges could be. I'd like to make sure that if we need to change the API we don't have to go through an entire release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants