Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random collection of geometric glyphs #2497

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Random collection of geometric glyphs #2497

merged 6 commits into from
Sep 12, 2024

Conversation

Logo121
Copy link
Contributor

@Logo121 Logo121 commented Sep 10, 2024

None of these have real justification, just being close enough to existing glyphs.

Preview

๐ ๐ก๐ข๐ฃ๐ค๐ฅ๐ฆ๐ง๐จ๐ฉ๐ช๐ซ๐ฌ๐ญ๐ฎ๐ฏ๐ฐ๐ฑ๐ฒ๐ณ๐ด๐ต๐ถ๐ท๐ธ
Pasted image 20240910225626
In QP:
Pasted image 20240910225643

โŽ„ โญ˜โญ™ โ›šโ›‹โ›โ›žโน™โนšโน›โนœ
Pasted image 20240910225713


Covered Range:

  • U+1D360 - U+1D376 (The rest of counting rod numerals block)
    • These are straightforward to make. Mostly extension of the existing tally mark code.
    • For the Counting Rod numerals, the strokes were scaled to be the same across all the ones and tens digits.
      • this made the Heavy monospace strokes too thin, so the horizontal strokes are modified to use a different sw.
  • U+2E59 - U+2E5C (Half parenthesis)
    • Copied code for half square brackets.
  • U+2384, U+26DA, U+26CB, U+26DD, U+26DE
    • Random collection of geometric symbols that can be done with some simple composition.
  • U+2B59 (Heavy Circled Saltire)
    • Implemented as "poweroff" with saltire for consistency. Ideally both should be actual circles, but Heavy Circle is also used as poweroff symbol, which Iosevka currently implements to be a standard "ring" instead.
    • If other symbols from the same set like โญ— (or even โญ–) are to be implemented, they may need to follow this as well, unless something is done with the power symbols.

@jmcwilliams403
Copy link
Contributor

Composition symbol (โŽ„) should always have the circle centered on the middle of the stroke of the edge of the square

@jmcwilliams403
Copy link
Contributor

Ideographic tally marks should be forced to a wide monospace (technically duospace?) square grid.

Also, I was told recently to drop Ideographic Space (U+3000) from my PR at #2484 so I suspect the same precedent exists for Ideographic tallies, but we'll see what Belleve thinks. I don't have high confidence though.

changes/31.6.2.md Outdated Show resolved Hide resolved
@Logo121 Logo121 marked this pull request as draft September 10, 2024 22:00
@Logo121
Copy link
Contributor Author

Logo121 commented Sep 10, 2024

I'll deal with the changes tomorrow, marking as draft now

Ideographic tally marks should be forced to a wide monospace (technically duospace?) square grid.

Wasn't aware of this requirement. It is marked as "Wide" in Unicode, but there are many other "Wide" glyphs that are implemented as Mosaic (both widths), or even just narrow width.

At least JuliaMono implements the whole Counting Rod block as halfwidth too, but again it's JuliaMono.

Please remove. Iosevka is not a CJK typeface.

Again I'm not so sure where's the line between "CJK" and "non-CJK" for symbols like these. For me it's just another tally system, which some non-CJK but pan-Unicode font supports because they are straightforward enough to make.

But just to be clear, do I remove the Ideograph Tallies only, or the other counting rods as well? Since their primary usage is in CJKV anyway.

@be5invis
Copy link
Owner

be5invis commented Sep 11, 2024

The ideographic tally marks are partial writing of the "ๆญฃ" (U+6B63) character.
See https://www.unicode.org/L2/L2016/16046-ideo-tally-marks.pdf.

But just to be clear, do I remove the Ideograph Tallies only, or the other counting rods as well? Since their primary usage is in CJKV anyway.

Remove the five ideographic tally marks only.
Keep the other counting rod symbols. Default them to wide, even in QP (esp. for U+1D369...1D36D, they should have spaces at left and right under QP).

@Logo121
Copy link
Contributor Author

Logo121 commented Sep 11, 2024

Ok the current revision should have the widths fixed now (the unspaced Tens glyphs looks like that on my computer, probably Noto. Nishikiteki also has this form iirc). The other changes (including the deletion) are applied accordingly.

But for monospaced version, I'm not sure what you mean by "Default them to Wide". Since they are not mosaics at the moment (following the Tally Marks), only Narrow version exists.
So do I:

  • Make the Counting Rod mosaics (but keep the behavior of Tally Marks as is);
  • Make the whole block mosaic, but somehow keep the Tally Mark One width for QP only (e.g. making them not Mosaics in QP); or
  • Make the Counting Rod Wide only (like the long arrows) and have them removed in Monospace-only versions?

The ideographic tally marks are partial writing of the "ๆญฃ" (U+6B63) character.
See https://www.unicode.org/L2/L2016/16046-ideo-tally-marks.pdf.

This part I know, but my point is when other font creators make glyphs for this block (which admittedly there are probably less than 10 fonts supporting the block completely), I doubt most would even care about those being CJK or not because they are easily abstractable as just "5 orthogonal lines in a certain pattern".

I'm also not quite aware of any technicalities or mechanisms that would make this font "CJK font" just because of the inclusion of these glyphs, unlike the squared units last time (#1651) or the ideographic space. Unless the "Ideographic" in its name is somehow triggering something?

@jmcwilliams403
Copy link
Contributor

I'm also not quite aware of any technicalities or mechanisms that would make this font "CJK font" just because of the inclusion of these glyphs, unlike the squared units last time (ref) or the ideographic space. Unless the "Ideographic" in its name is somehow triggering something?

Belleve has said in the past that inclusion of certain characters whose primary script is officially specified as something ideographic causes certain applications to treat the whole font as a CJK font, and if that were the user's actual intention then it would be better to use Sarasa Gothic instead, which includes Iosevka as a subset.

@be5invis
Copy link
Owner

be5invis commented Sep 12, 2024

Default them to Wide

nvm just ignore this comment. Your results are LGTM now.

@be5invis be5invis marked this pull request as ready for review September 12, 2024 01:04
@be5invis be5invis merged commit d319ad2 into be5invis:dev Sep 12, 2024
4 checks passed
jmcwilliams403 added a commit to jmcwilliams403/Iosevka that referenced this pull request Sep 19, 2024
be5invis pushed a commit that referenced this pull request Sep 19, 2024
* Improve serifs of `NRev`, optimize sw of `Eng`.

* Cleanup of #2497

* Cleanup of #2502

* Make `currency/somSign` follow `C`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants