Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move habitat dependencies #4

Merged
merged 8 commits into from
Aug 2, 2023
Merged

Move habitat dependencies #4

merged 8 commits into from
Aug 2, 2023

Conversation

jiuguangw
Copy link
Collaborator

Instead of commenting out the habitat dependencies, I moved them to a different group such that they can be installed via a pip install -e .[habitat]. This should also fix the import cv2 error in one of the tests. I didn't touch the pre-commit error.

@jiuguangw
Copy link
Collaborator Author

Oh well, I guess there is indeed a gym version conflict:

    zsos[habitat] 0.1 depends on gym>=0.26.2
    habitat-lab 0.2.520230729 depends on gym<0.23.1 and >=0.22.0

I think it was still worth it to move the habitat stuff to a different group, we'll just leave it alone for now...

@naokiyokoyamabd
Copy link
Contributor

Oh great, thanks! I was putting off figuring how to do different sets of installs, this is great to know about

@naokiyokoyamabd naokiyokoyamabd merged commit 3f72c6c into main Aug 2, 2023
1 of 2 checks passed
@naokiyokoyamabd naokiyokoyamabd deleted the jw/fix_ci branch August 2, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants