Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround race in Waitables handling #95

Merged
merged 4 commits into from
May 17, 2024

Conversation

mhidalgo-bdai
Copy link
Contributor

@mhidalgo-bdai mhidalgo-bdai commented May 16, 2024

This patch should fix ros2/rclpy#1284 for us, for now.

@mhidalgo-bdai
Copy link
Contributor Author

FYI @tkelestemur-bdai @llee-bdai

@mhidalgo-bdai mhidalgo-bdai force-pushed the mhidalgo-bdai/workaround-waitable-race branch from 53e5e09 to ad550cf Compare May 16, 2024 18:26
Signed-off-by: Michel Hidalgo <[email protected]>
@mhidalgo-bdai
Copy link
Contributor Author

CI is failing for unrelated reasons. Also present in main.

@mhidalgo-bdai mhidalgo-bdai merged commit 56ba72c into main May 17, 2024
3 checks passed
@mhidalgo-bdai mhidalgo-bdai deleted the mhidalgo-bdai/workaround-waitable-race branch May 17, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executors mishandle invalid waitables
2 participants