Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing deploy outputs #1926

Merged
merged 8 commits into from
Apr 19, 2024
Merged

fix: missing deploy outputs #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
228348a
Troubleshoot deploy outputs
DerekRoberts Apr 19, 2024
c7ac2a5
Trigger
DerekRoberts Apr 19, 2024
d1a5a7a
Outputs
DerekRoberts Apr 19, 2024
67695d6
Bump helper versions
DerekRoberts Apr 19, 2024
8819d24
Restore results and tests jobs
DerekRoberts Apr 19, 2024
26888a9
Restore results and tests jobs
DerekRoberts Apr 19, 2024
9b354db
Restore build job
DerekRoberts Apr 19, 2024
e60aae5
Remove trigger
DerekRoberts Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
# https://github.com/bcgov-nr/action-deployer-openshift
deploy-test:
name: Deploy (test)
uses: bcgov/quickstart-openshift-helpers/.github/workflows/[email protected].0
uses: bcgov/quickstart-openshift-helpers/.github/workflows/[email protected].1
secrets:
oc_namespace: ${{ secrets.OC_NAMESPACE }}
oc_token: ${{ secrets.OC_TOKEN }}
Expand All @@ -46,7 +46,7 @@ jobs:
deploy-prod:
name: Deploy (prod)
needs: [deploy-test, vars]
uses: bcgov/quickstart-openshift-helpers/.github/workflows/[email protected].0
uses: bcgov/quickstart-openshift-helpers/.github/workflows/[email protected].1
secrets:
oc_namespace: ${{ secrets.OC_NAMESPACE }}
oc_token: ${{ secrets.OC_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-close.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ concurrency:
jobs:
cleanup:
name: Cleanup and Images
uses: bcgov/quickstart-openshift-helpers/.github/workflows/[email protected].0
uses: bcgov/quickstart-openshift-helpers/.github/workflows/[email protected].1
secrets:
oc_namespace: ${{ secrets.OC_NAMESPACE }}
oc_token: ${{ secrets.OC_TOKEN }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pr-open.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
deploys:
name: Deploys
needs: [builds]
uses: bcgov/quickstart-openshift-helpers/.github/workflows/[email protected].0
uses: bcgov/quickstart-openshift-helpers/.github/workflows/[email protected].1
secrets:
oc_namespace: ${{ secrets.OC_NAMESPACE }}
oc_token: ${{ secrets.OC_TOKEN }}
Expand All @@ -46,7 +46,7 @@ jobs:

tests:
name: Tests
if: needs.deploys.triggered == 'true'
if: needs.deploys.outputs.triggered == 'true'
needs: [deploys]
uses: ./.github/workflows/.tests.yml
with:
Expand All @@ -55,7 +55,7 @@ jobs:
results:
name: PR Results
if: always() && !failure()
needs: [tests]
needs: [builds, deploys, tests]
runs-on: ubuntu-22.04
steps:
- run: echo "Workflow completed successfully!"
2 changes: 1 addition & 1 deletion .github/workflows/pr-validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
validate:
name: Validate PR
if: (! github.event.pull_request.draft)
uses: bcgov/quickstart-openshift-helpers/.github/workflows/[email protected].0
uses: bcgov/quickstart-openshift-helpers/.github/workflows/[email protected].1
with:
markdown_links: |
- [Frontend](https://${{ github.event.repository.name }}-${{ github.event.number }}-frontend.apps.silver.devops.gov.bc.ca)
Expand Down