Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): use label so Helm stops replacing secrets #1853

Merged
merged 1 commit into from
Mar 6, 2024
Merged

chore(ci): use label so Helm stops replacing secrets #1853

merged 1 commit into from
Mar 6, 2024

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Mar 6, 2024 •
edited by github-actions bot
Loading

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts self-assigned this Mar 6, 2024
@DerekRoberts DerekRoberts changed the title Use label so Helm stops replacing secrets chore(ci): use label so Helm stops replacing secrets Mar 6, 2024
@DerekRoberts DerekRoberts marked this pull request as ready for review March 6, 2024 19:33
@DerekRoberts DerekRoberts added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Mar 6, 2024
@DerekRoberts DerekRoberts enabled auto-merge (squash) March 6, 2024 19:34
@mishraomp
Copy link
Collaborator

lets put that as conditionals, as we don't want to persist pr deployment secret objects

@DerekRoberts DerekRoberts merged commit 96c0e4d into main Mar 6, 2024
26 of 27 checks passed
@DerekRoberts DerekRoberts deleted the chore/ci/ensureSecretsNotOverwritten branch March 6, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DerekRoberts DerekRoberts

Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerekRoberts @mishraomp