Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): PR environment purge #1778

Merged
merged 3 commits into from
Jan 29, 2024
Merged

fix(ci): PR environment purge #1778

merged 3 commits into from
Jan 29, 2024

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Jan 29, 2024 •
edited
Loading

Handle grep failing empty returns. Add additional error handling, since || true can hide problems.

NOTE: || : is an alternative to || true that cannot spawn processes.

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts self-assigned this Jan 29, 2024
@DerekRoberts DerekRoberts added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Jan 29, 2024
@DerekRoberts DerekRoberts linked an issue Jan 29, 2024 that may be closed by this pull request
PR env cleanup is reporting errors #1777
Closed
mishraomp
mishraomp approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DerekRoberts DerekRoberts marked this pull request as ready for review January 29, 2024 23:46
@DerekRoberts DerekRoberts added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit f505658 Jan 29, 2024
19 checks passed
@DerekRoberts DerekRoberts deleted the fix/envPurge branch January 29, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraomp mishraomp mishraomp approved these changes

Assignees

@DerekRoberts DerekRoberts

Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR env cleanup is reporting errors
2 participants
@DerekRoberts @mishraomp