Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-627: Device Endpoints #1404

Open
wants to merge 4 commits into
base: SIMSBIOHUB-627
Choose a base branch
from

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-627

Description of Changes

Add new device endpoints.

Testing Notes

n/a

Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
29.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 65.19337% with 63 lines in your changes missing coverage. Please review.

Please upload report for BASE (SIMSBIOHUB-627@bd8b6bb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...emetry-repositories/telemetry-device-repository.ts 5.00% 19 Missing ⚠️
...ect/{projectId}/survey/{surveyId}/devices/index.ts 61.70% 18 Missing ⚠️
...s/telemetry-repositories/telemetry-device-utils.ts 11.11% 16 Missing ⚠️
...ces/telemetry-services/telemetry-device-service.ts 25.00% 6 Missing ⚠️
...tId}/survey/{surveyId}/devices/{deviceId}/index.ts 95.31% 3 Missing ⚠️
...ct/{projectId}/survey/{surveyId}/devices/delete.ts 95.83% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             SIMSBIOHUB-627    #1404   +/-   ##
=================================================
  Coverage                  ?   47.04%           
=================================================
  Files                     ?      803           
  Lines                     ?    21609           
  Branches                  ?     3191           
=================================================
  Hits                      ?    10166           
  Misses                    ?    10859           
  Partials                  ?      584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant