Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-627 - Deployments #1398

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-627

Description of Changes

Add new Deployment2/Deployments2 endpoints/services/repos/types

Testing Notes

Basic QA.

@NickPhura NickPhura changed the base branch from dev to SIMSBIOHUB-627 October 17, 2024 19:04
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 93.36493% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (SIMSBIOHUB-627@5cc3796). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...services/deployment-services/deployment-service.ts 41.66% 7 Missing ⚠️
...ey/{surveyId}/deployments2/{deploymentId}/index.ts 95.77% 3 Missing ⚠️
...rveyId}/critters/{critterId}/deployments2/index.ts 97.05% 1 Missing ⚠️
...vey/{surveyId}/deployments/{deploymentId}/index.ts 0.00% 1 Missing ⚠️
...rojectId}/survey/{surveyId}/deployments2/delete.ts 95.83% 1 Missing ⚠️
...projectId}/survey/{surveyId}/deployments2/index.ts 95.65% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             SIMSBIOHUB-627    #1398   +/-   ##
=================================================
  Coverage                  ?   46.89%           
=================================================
  Files                     ?      797           
  Lines                     ?    21383           
  Branches                  ?     3176           
=================================================
  Hits                      ?    10028           
  Misses                    ?    10771           
  Partials                  ?      584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura requested a review from MacQSL October 21, 2024 18:05
@NickPhura NickPhura added the Ready For Review PR is ready for review label Oct 21, 2024
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
35.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛷️

@NickPhura NickPhura merged commit b400d57 into SIMSBIOHUB-627 Oct 21, 2024
16 of 19 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-627-deployment2 branch October 21, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants