Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Bad Deployments Bandaid #1390

Merged
merged 4 commits into from
Oct 4, 2024
Merged

BugFix: Bad Deployments Bandaid #1390

merged 4 commits into from
Oct 4, 2024

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

n/a

Description of Changes

Add feature flag guards to temporarily disable some of the bad deployment logic.

  • Don't return a bad deployment when multiple are found in bctw (return the 0th item)
  • Don't render the delete or checkbox actions in the bad deployment card on the frontend
  • Add a banner to tell the users about the ongoing issue, pending a fix.

Testing Notes

Deployments work as above.

Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.35%. Comparing base (98b4db5) to head (328c8c0).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...eys/telemetry/list/SurveyBadDeploymentListItem.tsx 0.00% 3 Missing ⚠️
...{projectId}/survey/{surveyId}/deployments/index.ts 83.33% 0 Missing and 1 partial ⚠️
...es/surveys/telemetry/list/SurveyDeploymentList.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1390   +/-   ##
=======================================
  Coverage   46.34%   46.35%           
=======================================
  Files         773      773           
  Lines       20834    20835    +1     
  Branches     3146     3147    +1     
=======================================
+ Hits         9656     9658    +2     
+ Misses      10598    10596    -2     
- Partials      580      581    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura merged commit 9748a1d into dev Oct 4, 2024
22 checks passed
@NickPhura NickPhura deleted the BugFix-Bad-Deployments branch October 4, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants