-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-621: Handle Bad Deployment Data #1382
Conversation
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1382 +/- ##
==========================================
- Coverage 48.42% 46.35% -2.08%
==========================================
Files 770 773 +3
Lines 20728 20831 +103
Branches 3132 3143 +11
==========================================
- Hits 10038 9656 -382
- Misses 10544 10595 +51
- Partials 146 580 +434 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦺
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌡️
Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-621
Description of Changes
Initial support for bad data (warning) response from deployments endpoints.
Testing Notes
If a survey has one or more deployments, and one or more of them reference a BCTW deployment ID that does not exist, the Manage Telemetry page should load successfully, showing a card in the left nav for each bad deployment record.