Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-621: Handle Bad Deployment Data #1382

Merged
merged 15 commits into from
Oct 1, 2024
Merged

SIMSBIOHUB-621: Handle Bad Deployment Data #1382

merged 15 commits into from
Oct 1, 2024

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-621

Description of Changes

Initial support for bad data (warning) response from deployments endpoints.

Testing Notes

If a survey has one or more deployments, and one or more of them reference a BCTW deployment ID that does not exist, the Manage Telemetry page should load successfully, showing a card in the left nav for each bad deployment record.

@NickPhura NickPhura added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 41.42012% with 99 lines in your changes missing coverage. Please review.

Project coverage is 46.35%. Comparing base (f357c3b) to head (f541585).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...es/surveys/telemetry/list/SurveyDeploymentList.tsx 0.00% 42 Missing ⚠️
...p/src/features/surveys/telemetry/TelemetryPage.tsx 0.00% 20 Missing ⚠️
api/src/utils/logger.ts 70.37% 2 Missing and 6 partials ⚠️
app/src/contexts/telemetryTableContext.tsx 0.00% 7 Missing ⚠️
.../telemetry/deployments/edit/EditDeploymentPage.tsx 0.00% 6 Missing ⚠️
...eys/telemetry/list/SurveyBadDeploymentListItem.tsx 0.00% 6 Missing ⚠️
...al/components/telemetry/SurveySpatialTelemetry.tsx 0.00% 4 Missing ⚠️
app/src/hooks/api/useSurveyApi.ts 50.00% 2 Missing ⚠️
...projectId}/survey/{surveyId}/deployments/delete.ts 96.55% 1 Missing ⚠️
...eatures/surveys/telemetry/table/TelemetryTable.tsx 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1382      +/-   ##
==========================================
- Coverage   48.42%   46.35%   -2.08%     
==========================================
  Files         770      773       +3     
  Lines       20728    20831     +103     
  Branches     3132     3143      +11     
==========================================
- Hits        10038     9656     -382     
- Misses      10544    10595      +51     
- Partials      146      580     +434     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc
Copy link
Collaborator

  • Missing key prop on the bad deployments list item
  • When a deployment with telemetry data is deleted, the telemetry UI table does not properly refresh; the rows remain but the deployment ID value of the rows gets removed

MacQSL
MacQSL previously approved these changes Oct 1, 2024
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

MacQSL
MacQSL previously approved these changes Oct 1, 2024
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦺

Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌡️

@NickPhura NickPhura merged commit bd416d6 into dev Oct 1, 2024
16 of 19 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-621 branch October 1, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants