TechDebt: Fix Patch System User SQL

[NickPhura]

Links to Jira Tickets

n/a

Description of Changes

• Fix Patch System User SQL
• Fix /self endpoint
  • The endpoint was rejecting any system user that had no user_guid, because the authorization check runs before the patch sql, and only uses the user_guid. It is safe to remove the authorization scheme because the endpoint already checks for a valid systemUserId, which can only exist if the connection is opened with the token successfully.
  • Rename endpoint function to getSelf for better readability.

Testing Notes

• When a user logs in, everything should work as expected: (the patch is called, the user context is set, and the self endpoint is called).
• If you manually set the user_guid column of your system_user record to null, and then log in, all of the calls should succeed, and your user_guid should be re-added to your system_user record.

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1341-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1341-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1341

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@27811fb). Learn more about missing BASE report.
Report is 1 commits behind head on dev.

Additional details and impacted files

@@          Coverage Diff           @@
##             dev    #1341   +/-   ##
======================================
  Coverage       ?   47.85%           
======================================
  Files          ?      728           
  Lines          ?    19890           
  Branches       ?     3130           
======================================
  Hits           ?     9518           
  Misses         ?     9775           
  Partials       ?      597           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mauberti-bc]

Tested locally by removing my GUID and it successfully patched my record 👍 Also added a missing key prop from an old PR