Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Loading Overlays On Data Grid Tables #1336

Merged
merged 8 commits into from
Aug 10, 2024
Merged

Update Loading Overlays On Data Grid Tables #1336

merged 8 commits into from
Aug 10, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Aug 8, 2024 •
edited by NickPhura
Loading

Links to Jira Tickets

  • N/A

Description of Changes

  • Moves the no data overlays outside of the data grid components so that the column headers don't show
    • Uses the LoadingGuard component to handle showing skeleton loaders and loading overlays
  • Changes heights of various data grid components on the summary, project, and survey pages

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Openshift URLs for the PR Deployment:

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Aug 8, 2024
@NickPhura NickPhura changed the title Update overlays on data grids Update Loading Overlays On Data Grid Tables Aug 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

NickPhura
NickPhura approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐌

@NickPhura NickPhura merged commit 2adb4ff into dev Aug 10, 2024
19 of 20 checks passed
@NickPhura NickPhura deleted the data-grid-overlays branch August 10, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickPhura NickPhura NickPhura approved these changes

Assignees
No one assigned
Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauberti-bc @NickPhura