Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TechDebt: Update Multer middleware and OpenAPI spec for file imports #1326

Merged
merged 23 commits into from
Jul 24, 2024
Merged

TechDebt: Update Multer middleware and OpenAPI spec for file imports #1326

merged 23 commits into from
Jul 24, 2024

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Jul 18, 2024 •
edited
Loading

Description of Changes

  • Extended express request object to contain files
  • Modified multer middleware to re-assign the req.body.media
  • Created schema for files + csv files
  • Created getFileFromRequest helper function
  • Updated upload/import endpoints to use getFileFromRequest
  • Updated upload/import endpoints to use new spec for incoming files

Testing Notes

  • All import / upload endpoints should work as expected

@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@MacQSL MacQSL changed the title TechDebt: Update multer middleware and OpenAPI spec for imports TechDebt: Update Multer middleware and OpenAPI spec for file imports Jul 18, 2024
@MacQSL MacQSL added the Ready For Review PR is ready for review label Jul 19, 2024
@MacQSL MacQSL self-assigned this Jul 19, 2024
@MacQSL MacQSL requested a review from NickPhura July 19, 2024 18:49
MacQSL
MacQSL commented Jul 19, 2024
View reviewed changes
api/src/app.ts Outdated Show resolved Hide resolved
@MacQSL MacQSL force-pushed the techdebt-import-media-spec branch from 3babb71 to 98cbf73 Compare July 19, 2024 21:57
@NickPhura NickPhura removed the Ready For Review PR is ready for review label Jul 22, 2024
@MacQSL MacQSL added the Ready For Review PR is ready for review label Jul 23, 2024
NickPhura
NickPhura previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

🚂

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

NickPhura
NickPhura approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@MacQSL MacQSL merged commit 85dd3a6 into dev Jul 24, 2024
19 of 20 checks passed
@MacQSL MacQSL deleted the techdebt-import-media-spec branch July 24, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickPhura NickPhura NickPhura approved these changes

Assignees

@MacQSL MacQSL

Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MacQSL @NickPhura