Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TechDebt: AWS V3 Update #1304

Merged
merged 10 commits into from
Jun 28, 2024
Merged

TechDebt: AWS V3 Update #1304

merged 10 commits into from
Jun 28, 2024

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Jun 4, 2024

Links to Jira Tickets

n/a

Description of Changes

API

Bump AWS package from V2 to V3.

  • Fix outdated api references, etc.

APP

Remove some attachment related unused code for resubmitting attachments (part of the old biohub publish workflow)

Testing Notes

Reading/Writing files to S3 storage works as before.

@NickPhura NickPhura added the Not Ready For Review Addressing feedback and/or refactoring label Jun 4, 2024
@NickPhura NickPhura added Early Feedback Welcome PR is not finished, but early review feedback is welcomed and removed Not Ready For Review Addressing feedback and/or refactoring labels Jun 18, 2024
@NickPhura NickPhura marked this pull request as draft June 21, 2024 19:45
@NickPhura NickPhura marked this pull request as ready for review June 21, 2024 23:58
mauberti-bc
mauberti-bc previously approved these changes Jun 24, 2024
Copy link
Collaborator

@mauberti-bc mauberti-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested uploading and deleting files locally and it worked as expected 👍

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 55.88235% with 15 lines in your changes missing coverage. Please review.

Project coverage is 49.16%. Comparing base (ce03ca4) to head (ab1920e).

Current head ab1920e differs from pull request most recent head 4fba913

Please upload reports for the commit 4fba913 to get more accurate results.

Files Patch % Lines
api/src/utils/file-utils.ts 55.00% 9 Missing ⚠️
...attachments/list/AttachmentsListItemMenuButton.tsx 0.00% 2 Missing ⚠️
api/src/paths/resources/list.ts 0.00% 0 Missing and 1 partial ⚠️
api/src/services/observation-service.ts 0.00% 1 Missing ⚠️
api/src/services/telemetry-service.ts 0.00% 1 Missing ⚠️
api/src/utils/media/media-utils.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1304      +/-   ##
==========================================
- Coverage   49.21%   49.16%   -0.05%     
==========================================
  Files         639      637       -2     
  Lines       17707    17662      -45     
  Branches     2787     2779       -8     
==========================================
- Hits         8714     8684      -30     
+ Misses       8409     8399      -10     
+ Partials      584      579       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura
Copy link
Collaborator Author

Tests are fixed!

@NickPhura NickPhura added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Jun 25, 2024
@NickPhura NickPhura assigned NickPhura and unassigned NickPhura Jun 26, 2024
Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@mauberti-bc mauberti-bc merged commit 9113f6a into dev Jun 28, 2024
16 of 17 checks passed
@NickPhura NickPhura deleted the np_techdebt_aws_v3 branch June 28, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants