Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Add Missing Env Var For Deployed App. #1190

Merged
merged 1 commit into from
Jan 4, 2024
Merged

BugFix: Add Missing Env Var For Deployed App. #1190

merged 1 commit into from
Jan 4, 2024

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

n/a

Description of Changes

Add Missing Env Var For Deployed App.

  • Vars have to be listed in both the configContext.tsx (for local instances) and server/index.js (for deployed instances).

Testing Notes

  • Publish button on survey page is visible.

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf6fbb1) 58.19% compared to head (7b2c79a) 58.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1190   +/-   ##
=======================================
  Coverage   58.19%   58.19%           
=======================================
  Files         590      590           
  Lines       17985    17985           
  Branches     2773     2773           
=======================================
  Hits        10466    10466           
  Misses       6833     6833           
  Partials      686      686           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura merged commit 5517e88 into dev Jan 4, 2024
20 checks passed
@NickPhura NickPhura deleted the npBugFix branch January 4, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants