Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Misc #1185

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Bug Fix: Misc #1185

merged 3 commits into from
Dec 18, 2023

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Dec 18, 2023

Links to Jira Tickets

n/a

Description of Changes

Fix geojson zod schema usage (my fault from previous PR)

  • Was causing the survey page to fail to load.
    Update platform publish classes to match latest version expected by BioHub.

Testing Notes

  • Survey related pages load correctly once again.
  • Publish works (pending matching changes on the BioHub side which have not yet been merged to the feature branch)

al-rosenthal
al-rosenthal previously approved these changes Dec 18, 2023
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran this locally and it looks good 🛠️

al-rosenthal
al-rosenthal previously approved these changes Dec 18, 2023
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7bfbf9c) 58.15% compared to head (1610ea4) 58.17%.

Files Patch % Lines
api/src/services/platform-service.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1185      +/-   ##
==========================================
+ Coverage   58.15%   58.17%   +0.02%     
==========================================
  Files         590      590              
  Lines       17945    17952       +7     
  Branches     2762     2763       +1     
==========================================
+ Hits        10436    10444       +8     
  Misses       6825     6825              
+ Partials      684      683       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Assign additional information to description field.
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 📦

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏂

@curtisupshall curtisupshall changed the title BugFIx: Misc Bug Fix: Misc Dec 18, 2023
@curtisupshall curtisupshall merged commit 99c7762 into dev Dec 18, 2023
19 checks passed
@curtisupshall curtisupshall deleted the npBugFixes-4 branch December 18, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants